[PIPE2D-979] 2d sky subtraction creates patches of negative data Created: 18/Feb/22  Updated: 25/Feb/22  Resolved: 25/Feb/22

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Normal
Reporter: ncaplar Assignee: price
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File Screen Shot 2022-02-17 at 1.24.53 PM.png    
Reviewers: hassan

 Description   

As reported by Kiyoto Yabe the 2d sky subtraction seems to create large patches of negative values. Wherever the algorithm seems to apply the subtraction, the result are large negative values. It seems likely that normalization has a bug somewhere. Might be connected with PIPE2D-972. See the result here

The code to generate the images was

reduceExposure.py /projects/HSC/PFS/Subaru --calib /projects/HSC/PFS/Subaru/CALIB-SuNSS --rerun hassans/PIPE2D-977 --id visit=46588 arm=r -c measurePsf.oversampleFactor=11 measurePsf.version=Aug0121_v1 measurePsf.targetSize=21 doWriteCalexp=True doSubtractSky2d=True doMeasurePsf=True isr.doFlat=False

 Comments   
Comment by price [ 18/Feb/22 ]

This was much simpler than normalisation problems. The results of the photometry with the NevenPsf weren't being used, so the PSF didn't match the photometry.

Comment by hassan [ 25/Feb/22 ]

All changes in PR https://github.com/Subaru-PFS/drp_stella/pull/248 look fine.

Comment by price [ 25/Feb/22 ]

Merged.

Generated at Sat Feb 10 16:00:44 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.