[PIPE2D-978] mergeArms fails when processing SuNSS data Created: 18/Feb/22  Updated: 18/Feb/22  Resolved: 18/Feb/22

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Normal
Reporter: hassan Assignee: hassan
Resolution: Done Votes: 0
Labels: SuNSS
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Story Points: 1
Reviewers: price

 Description   

When running mergeArms.py

mergeArms.py /projects/HSC/PFS/Subaru --calib /projects/HSC/PFS/Subaru/CALIB-PFI-20211220 --rerun=hassans/sunss/2022jan_apcorrb_mergeArms_2022-02-04_11-18-01 -j10 --doraise --id visit=71280^71281[...] arm=b^r

(full list of visits truncated for brevity)

The following error is raised:

File "/tigress/HSC/PFS/stack/20190925/stack/miniconda3-4.5.12-1172c30/Linux64/drp_stella/w.2022.04/python/pfs/drp/stella/mergeArms.py", line 196, in runDataRef
results = self.run(spectra, pfsConfig, lsfList)
File "/tigress/HSC/PFS/stack/20190925/stack/miniconda3-4.5.12-1172c30/Linux64/drp_stella/w.2022.04/python/pfs/drp/stella/mergeArms.py", line 153, in run
lsfList = [self.mergeLsfs(ll, ss) for ll, ss in zip(lsfList, spectra)]
File "/tigress/HSC/PFS/stack/20190925/stack/miniconda3-4.5.12-1172c30/Linux64/drp_stella/w.2022.04/python/pfs/drp/stella/mergeArms.py", line 153, in <listcomp>
lsfList = [self.mergeLsfs(ll, ss) for ll, ss in zip(lsfList, spectra)]
File "/tigress/HSC/PFS/stack/20190925/stack/miniconda3-4.5.12-1172c30/Linux64/drp_stella/w.2022.04/python/pfs/drp/stella/mergeArms.py", line 415, in mergeLsfs
return

Unknown macro: {ff}

File "/tigress/HSC/PFS/stack/20190925/stack/miniconda3-4.5.12-1172c30/Linux64/drp_stella/w.2022.04/python/pfs/drp/stella/mergeArms.py", line 415, in <dictcomp>
return

Unknown macro: {ff}

File "/tigress/HSC/PFS/stack/20190925/stack/miniconda3-4.5.12-1172c30/Linux64/drp_stella/w.2022.04/python/pfs/drp/stella/mergeArms.py", line 415, in <listcomp>
return

Unknown macro: {ff}

KeyError: 2

 Comments   
Comment by hassan [ 18/Feb/22 ]

It appears that the fiberId is taken from the list of Lsfs, which contains more fiberIds than in the spectra. For example, fiberId=2 is in the Lsf list but there is no spectrum for that. The warning seems to mention that, but it doesn't seem to be corrected for.

Comment by hassan [ 18/Feb/22 ]

Fix merged to master.

Generated at Sat Feb 10 16:00:42 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.