[PIPE2D-977] Simplify sky fiber selection for subtractSky2d Created: 18/Feb/22 Updated: 25/Feb/22 Resolved: 25/Feb/22 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | price | Assignee: | price |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Reviewers: | hassan |
| Description |
|
The SubtractSky2dTask currently hard-wires use of TargetType.SKY fibers, but, SuNSS exposures don’t have any SKY fibers. The DummySubtractSky2dTask is much more configurable: it allows the user to specify what target types to use for sky, and allows filtering that list (e.g., odd fibers only). I propose to copy the mechanism to SubtractSky2dTask, which will allow users to test sky subtraction without the need to hack the pfsConfig beforehand. |
| Comments |
| Comment by price [ 25/Feb/22 ] |
|
Merged. |