[PIPE2D-966] Investigate failed weekly 2022-01-02 Created: 05/Jan/22 Updated: 11/Jan/22 Resolved: 11/Jan/22 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | price | Assignee: | price |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Reviewers: | hassan |
| Description |
====================================================================== FAIL: testResiduals (__main__.ArcTestCase_brn_39) (arm='b', fiberId=2) Test that wavelength fit residuals are reasonable ---------------------------------------------------------------------- Traceback (most recent call last): File "/scratch/pprice/jenkins/weekly/2022-01-02/build/stack/miniconda3-4.5.12-1172c30/Linux64/pfs_pipe2d/w.2022.01/python/pfs/pipe2d/weekly/test_weekly.py", line 139, in testResiduals self.assertFloatsAlmostEqual(robustRms, 0.0, atol=atol) File "/scratch/pprice/jenkins/weekly/2022-01-02/build/stack/miniconda3-4.5.12-1172c30/Linux64/utils/18.1.0/python/lsst/utils/tests.py", line 735, in assertFloatsAlmostEqual testCase.assertFalse(failed, msg="\n".join(errMsg)) AssertionError: True is not false : 0.079973473945946 != 0.0; diff=0.079973473945946/0.079973473945946=1.0 with rtol=2.220446049250313e-16, atol=0.05 |
| Comments |
| Comment by price [ 06/Jan/22 ] |
|
Discovered that applyExclusionZone wasn't working following the changes to the backend. Fixed that, and added some tests. |
| Comment by hassan [ 08/Jan/22 ] |
|
In general changes look fine, but please see comment in pull request regarding the scenario where two lines with exactly the same wavelength (well, to numerical precision) are not marked as rejected. |
| Comment by price [ 11/Jan/22 ] |
|
Not flagging lines with the same wavelength was the existing behaviour, so we agreed that changes to that can be made in another ticket. Merged. |