[PIPE2D-952] Spurious features appear in merged spectra Created: 20/Nov/21  Updated: 21/Dec/21  Resolved: 21/Dec/21

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Normal
Reporter: rhl Assignee: price
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File pfsArm.png     PNG File pfsMerged.png     PNG File pipe2d-952-fixed.png    
Story Points: 3
Sprint: 2DDRP-2021 A12

 Description   

For 'visit': 69546, 'arm': 'r', 'spectrograph': 1 there are features in the merged spectra that don't appear in the arm spectra. Please investigate and fix.

This is using the CALIB-PFI-20211108 calibs (copied to Hilo)



 Comments   
Comment by rhl [ 21/Dec/21 ]

Looks much better. What was the problem? Calibs?

Comment by price [ 21/Dec/21 ]

Between PIPE2D-948 (and new calibs CALIB-PFI-20211220) and PIPE2D-799 and possibly isr.doApplyGains=True, this appears to have been resolved. I'll have a quick play to see if I can determine which one is responsible.

(lsst-scipipe) pprice@tiger2-sumire:/scratch/pprice/pipe2d-952 $ reduceExposure.py /projects/HSC/PFS/Subaru --calib /projects/HSC/PFS/Subaru/CALIB-PFI-20211220 --rerun price/pipe2d-952 --id visit=69546 -c isr.doFlat=False isr.doApplyGains=True repair.doCosmicRay=False doAdjustDetectorMap=False -j 2
(lsst-scipipe) pprice@tiger2-sumire:/scratch/pprice/pipe2d-952 $ mergeArms.py /projects/HSC/PFS/Subaru --calib /projects/HSC/PFS/Subaru/CALIB-PFI-20211220 --rerun price/pipe2d-952 --id visit=69546 -c doSubtractSky1d=False

>>> from lsst.daf.persistence import Butler
>>> butler = Butler("/projects/HSC/PFS/Subaru/rerun/price/pipe2d-952")
>>> merged = butler.get("pfsMerged", visit=69546)
>>> fig, axes = merged.plot(fiberId=[409, 501], show=False)
>>> axes.set_xlim(680, 740)
>>> axes.set_ylim(-300, 700)
>>> axes.legend()
>>> fig.show()
Comment by price [ 21/Dec/21 ]

Fixed by the reworked normalisation code in PIPE2D-799.

Generated at Sat Feb 10 16:00:18 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.