[PIPE2D-951] support windowed option in detrend.py and runIsr.py Created: 18/Nov/21  Updated: 17/Dec/21  Resolved: 19/Nov/21

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Normal
Reporter: rhl Assignee: price
Resolution: Done Votes: 0
Labels: EngRun
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Reviewers: price

 Description   

PIPE2D-914 adds a config option -c windowed=True to support windowed reads. Please make this work for the other command line options too. It also needs to work if we're running just IsrTask (although admittedly we could just set overscanFitType = "MEDIAN", but that seems like something that we don't want users to know.

I'll push my version that does this, but price may not like the way I did it as it copies some of the windowed magic into multiple places.

 Comments   
Comment by rhl [ 18/Nov/21 ]

https://github.com/Subaru-PFS/obs_pfs/pull/112

Comment by hassan [ 18/Nov/21 ]

Switching the status to In Review as rhl has created a Pull Request, so I assume that a ticket review is requested at this time.

Comment by rhl [ 19/Nov/21 ]

Actually I didn't put it in review on purpose, as I asked Paul whether he liked my implementation.  He ended up reviewing rather than rewriting, so I've merged/pushed and am marking the ticket as Done.

Generated at Sat Feb 10 16:00:17 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.