[PIPE2D-948] reduceArc: restore the use of continuum as well as arc data Created: 17/Nov/21  Updated: 21/Dec/21  Resolved: 21/Dec/21

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: hassan Assignee: price
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Story Points: 3
Sprint: 2DDRP-2021 A11, 2DDRP-2021 A12
Reviewers: hassan

 Description   

reduceArc should combine both continuum and arc data for detectormap construction. Following some earlier refactoring, the use of the continuum had been unfortunately omitted.

Please re-introduce this.

This affects in particular the construction of detector maps in the blue band, which have limited calibration lines to utilize.



 Comments   
Comment by price [ 09/Dec/21 ]

Here's what I got from visit=68351^68100 arm=b:

reduceArc.fitDetectorMap INFO: Final result: chi2=859353.902769 dof=2055514 xRMS=0.020993 yRMS=0.046308 xSoften=0.016511 ySoften=0.000000 from 2052486 lines
reduceArc.fitDetectorMap INFO: Stats for NeI: chi2=9837.739911 dof=7386 xRMS=0.028687 yRMS=0.046308 xSoften=0.014554 ySoften=0.022390 from 4358 lines
reduceArc.fitDetectorMap INFO: Stats for Trace: chi2=849516.162857 dof=2046798 xRMS=0.020977 yRMS=nan xSoften=0.016523 ySoften=0.000000 from 2048128 lines
reduceArc.fitDetectorMap INFO: Stats for fiberId=2: chi2=2253.391746 dof=735 xRMS=0.032821 yRMS=0.029681 xSoften=0.039527 ySoften=0.000000 from 2060 lines (2055 Trace, 5 NeI)
reduceArc.fitDetectorMap INFO: Stats for fiberId=158: chi2=1045.625887 dof=2227 xRMS=0.017830 yRMS=0.026322 xSoften=0.013347 ySoften=0.000000 from 3551 lines (3545 Trace, 6 NeI)
reduceArc.fitDetectorMap INFO: Stats for fiberId=338: chi2=2088.594326 dof=2215 xRMS=0.024847 yRMS=0.054143 xSoften=0.023516 ySoften=0.000000 from 3530 lines (3515 Trace, 15 NeI)
reduceArc.fitDetectorMap INFO: Stats for fiberId=494: chi2=1239.270034 dof=2227 xRMS=0.019248 yRMS=0.062852 xSoften=0.015534 ySoften=0.000000 from 3549 lines (3541 Trace, 8 NeI)
reduceArc.fitDetectorMap INFO: Stats for fiberId=650: chi2=2408.785240 dof=2242 xRMS=0.026586 yRMS=0.055242 xSoften=0.026411 ySoften=0.000000 from 3558 lines (3544 Trace, 14 NeI)
Comment by hassan [ 18/Dec/21 ]

Suggested changes in PR https://github.com/Subaru-PFS/drp_stella/pull/238 look acceptable.

Comment by price [ 21/Dec/21 ]

Merged.

Generated at Sat Feb 10 16:00:16 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.