[PIPE2D-947] rename makePfsDesign.py so that we can import into the pfs.utils namespace Created: 15/Nov/21  Updated: 17/Nov/21  Resolved: 17/Nov/21

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Normal
Reporter: rhl Assignee: rhl
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Reviewers: hassan

 Description   

Because the function makePfsDesign appears in the file makePfsDesign.py, we can't import it into the pfs.utils namespace or import it from the module without shadowing the module which may be OK but is scary.  Please rename the file to pfsDesignUtils.py

 



 Comments   
Comment by rhl [ 15/Nov/21 ]

At the same time, please add support for setting designName

Comment by rhl [ 15/Nov/21 ]

https://github.com/Subaru-PFS/pfs_utils/pull/40

Comment by hassan [ 15/Nov/21 ]

No objections with the proposed changes in the above pull request.

Generated at Sat Feb 10 16:00:15 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.