[PIPE2D-937] Extraction is producing NaNs in the calexp Created: 09/Nov/21 Updated: 10/Nov/21 Resolved: 10/Nov/21 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | price | Assignee: | price |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Sprint: | 2DDRP-2021 A11 |
| Reviewers: | hassan |
| Description |
|
rhl reports that with |
| Comments |
| Comment by price [ 10/Nov/21 ] |
|
Tracked this to the continuum subtraction context manager, where the continuum image has NaN values so subtracting and then adding leaves NaN values in the original image. The fiberTraces have NaN values because the fiberProfile normalisation has NaN values. Fixed this by masking out the NaN values in the fiberTraces and continuum-subtracted image, and changing the context manager to restore the original completely rather than adding the continuum back. |
| Comment by hassan [ 10/Nov/21 ] |
|
No problems found in suggested changes. One comment, and better deferred to a separate ticket after the engineering run: can we have a check at the unit test and/or integration test or weekly test level that demonstrates that the extraction is performing as expected? |
| Comment by price [ 10/Nov/21 ] |
|
Filed PIPE2D-940 to extend the tests. Merged. |