[PIPE2D-929] Psf modelling with fiber illumination constant across spots in the same fiber with 2+ spots Created: 02/Nov/21  Updated: 21/Dec/21  Resolved: 21/Dec/21

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: ncaplar Assignee: ncaplar
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File improvment_defocus_focus.png     PNG File m4 frd_sigma_renormalized.png     PNG File single_defocused_example.png    
Issue Links:
Relates
relates to PIPE2D-931 Speed up creation of variance images ... Done
Story Points: 5
Sprint: 2DDRP-2021 A12

 Description   

At the moment, the algorithm implemented in PIPE2D-615 takes only two spots and analyzes them simultaneously. Expand this to take any number of spots to analyze at the same time. 



 Comments   
Comment by ncaplar [ 18/Nov/21 ]

I have implemented the changes and sent a test run to the cluster before I went to Hawaii (started on Nov13). It seems that calculation is not finished by Nov17, indicating some sort of problem.

Comment by ncaplar [ 19/Nov/21 ]

The problem was that I have filled my user directory on tigress. I have cleaned my user directory (which had some old reduced data that should be in rerun directories, and many intermediate files from creation of poststamp images which could be deleted) and rerouted my outputs to 

scratch/gpfs

which is a) actually proper way to do it and b) has more space.

I have noticed that the code is slower than I expected, i.e., when I analyze 8 spots it is around 50% slower than analyzing 8 individual images. I am making a small profiling run to see what is happening. 

Comment by ncaplar [ 20/Nov/21 ]

The slowdown on della was happening because I did not execute 

export OMP_NUM_THREADS=1

before running my code (see https://jira.lsstcorp.org/browse/DM-4714)

Comment by ncaplar [ 21/Dec/21 ]

I implemented this code some time ago already. I will shortly describe the figures I attached here and which I described during one of the telecons.

You can see that the code has been correctly manipulated so that the parameters describing focal ratio degradation are same for all of the spots in the fiber.

`Improvment` measure that I use to determine how well the algorithm is doing. In general, the `improvment` shows the same features as in previous versions of the fitting procedure when I was fitting individual spots.

this figures shows an example of a single defocused spot. The quality is comparable to previous versions - but you can see some problems in modelling the illumination (e.g., struts). I will elaborate more on this in the follow-up tickets.

Generated at Sat Feb 10 15:59:57 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.