[PIPE2D-925] IngestPfsImages should not create a PfsConfig by default if none exists Created: 27/Oct/21 Updated: 13/Jan/22 |
|
| Status: | Open |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | hassan | Assignee: | hassan |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Story Points: | 1 | ||||||||
| Description |
|
ingestPfsImages.py ingests raw exposures to the specified raw data repository, and the corresponding pfsConfig file for that exposure. If the pfsConfig file does not exist, then by default it creates one from the appropriate pfsDesign file (which is found from the value of the pfsDesignId in the raw exposure header): During normal operations, the pfsConfig will be created by the ICS software. So the non-existence of a pfsConfig file for that exposure should be raised immediately as an error. As the facility of creating a pfsConfig if one does not exist is useful for development purposes and commissioning it should be retained. So instead please update the code such that the creation of a pfsConfig file if one does not exist is provided as a configuration parameter, which by default is off. |
| Comments |
| Comment by cloomis [ 27/Oct/21 ] |
|
This covers PIPE2D-919. The only point from that which needs to be carried over is that the pfsConfigs are likely to be sparse, with one per visit0 instead of one per visit. If that will be a problem we can reconsider on the ICS side. |
| Comment by price [ 27/Oct/21 ] |
|
Will the visit0 be recorded in the header? That would be easiest for us. |
| Comment by cloomis [ 28/Oct/21 ] |
|
Yes, that'd work nicely. |