[PIPE2D-913] pfsObject noise is incorrect Created: 06/Oct/21 Updated: 16/Oct/21 Resolved: 16/Oct/21 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | price | Assignee: | price |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Story Points: | 2 | ||||||||
| Sprint: | 2DDRP-2021 A 10 | ||||||||
| Reviewers: | hassan | ||||||||
| Description |
|
vlebrun reports ( |
| Comments |
| Comment by price [ 13/Oct/21 ] |
|
This was due to a subtle effect in PfsFiberArraySet.__itruediv__. In flux calibration, we divide the spectrum by the spectrum's normalisation. But in the process of that division, the normalisation is changed, which meant that the flux and the variance were not divided through by the same values. |
| Comment by hassan [ 14/Oct/21 ] |
|
Changes makes sense. For changes in drp_stella https://github.com/Subaru-PFS/drp_stella/pull/225 consider using a common set of functions to avoid code duplication. |
| Comment by price [ 16/Oct/21 ] |
|
After some thought, I would like to keep the implementations for PfsFiberArray and PfsFiberArraySet distinct, because I think if we try to combine them we'll end up with a function that's more about the exceptions than the common behaviour. But I did take the opportunity to reduce code duplication by making the division implementations use the multiplication. Thanks for the suggestion! Merged. |