[PIPE2D-905] Restrict writing of pfsDesign/pfsConfig subsets Created: 24/Sep/21  Updated: 01/Oct/21  Resolved: 30/Sep/21

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Normal
Reporter: price Assignee: price
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to PIPE2D-910 Update pfsDesignIds when subsetting p... Open
Story Points: 1
Sprint: 2DDRP-2021 A 9
Reviewers: hassan

 Description   

PfsDesign and PfsConfig can now be subsets of the original. Writing these subsets may clobber the original, since a subset still retains the same pfsDesignId. Add some safeguards to prevent this.

 Comments   
Comment by price [ 24/Sep/21 ]

Allow writing a subset only when the user specifies allowSubset=True.

Comment by hassan [ 29/Sep/21 ]

Changes are fine. Might be useful to have an isSubset() method to enable a user to see if the object can be written out or not prior to any write.

Comment by price [ 30/Sep/21 ]

Promoted the _isSubset to isSubset. Will merge following integration test.

Comment by price [ 30/Sep/21 ]

Integration test failed due to PIPE2D-908. However, the datamodel tests passed in the integration test and on my own system, which should be sufficient.

Merged.

Generated at Sat Feb 10 15:59:33 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.