[PIPE2D-904] Add aperture corrections Created: 23/Sep/21 Updated: 16/Oct/21 Resolved: 16/Oct/21 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | price | Assignee: | price |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Story Points: | 5 |
| Sprint: | 2DDRP-2021 A 10 |
| Reviewers: | hassan |
| Description |
|
If the fidelity of the PSF varies as a function of fiber or wavelength within a fiber (which could be due to the PSF model failing to follow real variation, or the PSF model variation not being accurate), then we need to calculate and apply aperture corrections. |
| Comments |
| Comment by rhl [ 30/Sep/21 ] |
|
I interpret "position within a fiber" to mean, "with wavelength". |
| Comment by price [ 13/Oct/21 ] |
|
Got this working, and it appears to help. |
| Comment by hassan [ 14/Oct/21 ] |
|
I've left a comment in https://github.com/Subaru-PFS/drp_stella/pull/224 about the assumptions for ReferenceLineStatus bit masks. Not sure why a single bit is assumed to be set. Please clarify. |
| Comment by hassan [ 15/Oct/21 ] |
|
I think my confusion is now resolved. No further comments. |
| Comment by price [ 16/Oct/21 ] |
|
Merged. |