[PIPE2D-886] Generate a new weekly dataset Created: 18/Aug/21 Updated: 21/Aug/21 Resolved: 21/Aug/21 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | hassan | Assignee: | hassan |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Story Points: | 5 | ||||||||||||||||||||
| Sprint: | 2DDRP-2021 A 8 | ||||||||||||||||||||
| Reviewers: | price | ||||||||||||||||||||
| Description |
|
We've had a significant number of changes in the 2D simulator and datamodel since the last time the weekly dataset was built. Rebuild the weekly dataset, fixing any problems found during that process. |
| Comments |
| Comment by price [ 20/Aug/21 ] |
|
Where's the regenerated data? pfs_pipe2d hasn't been updated to run the weekly from the new location. We need documentation of the spectral catalog YAML file format, and a good example or default. |
| Comment by hassan [ 20/Aug/21 ] |
|
Code updated based on comments and a short README added to the drp_instmodel repository explaining the spectral catalog YAML file format. Related to this, spectral catalog data now moved to /projects/HSC/PFS/Simulator and new weekly data now under /projects/HSC/PFS/weekly-20210819/ on the Princeton cluster. |
| Comment by price [ 21/Aug/21 ] |
|
Please note that the directory is /projects/HSC/PFS/simulator (capitalisation). |
| Comment by rhl [ 21/Aug/21 ] |
|
The number seems to be a catId, so it might be appropriate providing that a README describing the catalogues were added to {{ /projects/HSC/PFS/simulator/pfsSimObjects}}
|
| Comment by price [ 21/Aug/21 ] |
|
We need integer catId, but there's a YAML file that translates between the integer catId and the directory name, so we should make the directory names meaningful to humans. |
| Comment by hassan [ 21/Aug/21 ] |
|
Sean, Paul and I have agreed on the directory names containing the spectra and I've updated the contents of the /projects/HSC/PFS/simulator, added a README.md and updated the README.md for the drp_instmodel branch. |