[PIPE2D-88] Fix indentation in Math.cc Created: 30/Sep/16 Updated: 24/Feb/17 Resolved: 24/Feb/17 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Major |
| Reporter: | aritter | Assignee: | aritter |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Story Points: | 0.25 |
| Sprint: | 2014-16 |
| Reviewers: | cloomis |
| Comments |
| Comment by aritter [ 28/Dec/16 ] |
|
indentations and deletion of commented out lines only. should be a quick review... |
| Comment by swinbank [ 31/Jan/17 ] |
|
Hey cloomis: this came up at today's meeting. Do you have an ETA on a review? |
| Comment by swinbank [ 02/Feb/17 ] |
|
Setting back to cloomis for review. |
| Comment by cloomis [ 02/Feb/17 ] |
|
If this really is just an indentation cleanup, can I suggest re-starting from a merged HEAD? Especially if you are just using a program to reformat. The number of hard-to-judge "diff changes" in the first commit on As an aside, I should look into how to adjust diff options to handle this kind of changeset. |
| Comment by cloomis [ 11/Feb/17 ] |
|
Much better, thanks. This is definitely cleanly reviewable and mergeable. Functionally, I check off on this. But: if you have a tool you can rerun with args, can you run with a line-length limit of 110 chars? There are quite a few long lines left, some exceeding 250 characters. Another note on the same subject: your formatter did insert indents for the namespaces: #include "pfs/drp/stella/math/Math.h"
namespace pfs {
namespace drp {
namespace stella {
namespace math {
template< typename T, typename U >
[ ... ]
If there is an option to disable that you would lessen the visual price. |
| Comment by aritter [ 14/Feb/17 ] |
|
I removed the line indent for the namespaces and filed a ticket to reduce the line length to the permitted 110 characters. Can I merge? |
| Comment by cloomis [ 14/Feb/17 ] |
|
Yes. Please do. |
| Comment by aritter [ 24/Feb/17 ] |
|
Merged into master |