[PIPE2D-874] Centering/offset/interpolation - fix to PIPE2D 778 and PIPE2D-777 Created: 28/Jul/21  Updated: 05/Aug/21  Resolved: 05/Aug/21

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: ncaplar Assignee: ncaplar
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File after_872.png     PNG File before_872.png    
Issue Links:
Blocks
blocks PIPE2D-857 Apply sky subtraction, deduced from D... Done
Relates
relates to PIPE2D-777 Difference in centering between pipel... Done
relates to PIPE2D-778 Difference between pipeline and 2d al... Done
relates to PIPE2D-872 Expose function resampleKernelImage t... Done
Story Points: 4
Sprint: 2DDRP-2021 A 7, 2DDRP-2021 A 8

 Description   

I have realized that the code, as I implemented it in PIPE2D-777 and PIPE2D-778 is wrong. What the code was doing was not summing over the pixel when doing the final downsampling, but just outputing the central value. This was due to me simply copy-pasting the galsim snippet code which correctly applies the offset (interpolating on subpixel values with Lancoz5) and not realizing the difference in this final step. This difference became obvious when using the code provided by Paul in PIPE-872. I have now implemented the proper dowsampling, which is the same as in PIPE-872.

I have to rerun the solutions being prepared for PIPE2D-857, due to this change (see the Figure). Given that the effect on defocused images and Zernike parameters is minimal, I will run shorter runs as we have to significantly modify only few parameters determining the size in focus.



 Comments   
Comment by ncaplar [ 05/Aug/21 ]

The change was applied (internal version 0.47f), solution have been run (internal name - Aug01 solution) and applied to DCB and SuNNS data. There are no obvious large downsampling and centering issues. Some related problems have been noticed - I will close this ticket now and open tickets with those problems.

Generated at Sat Feb 10 15:59:13 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.