[PIPE2D-871] Code implementation of the radial velocity estimate for flux calibration Created: 19/Jul/21  Updated: 29/Sep/21  Resolved: 29/Sep/21

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Normal
Reporter: Takuji Yamashita Assignee: sogo.mineo
Resolution: Done Votes: 0
Labels: flux-calibration
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Blocks
blocks PIPE2D-371 Write code to store flux calibration ... Done
Epic Link: flux calibration
Reviewers: price

 Description   

Write a code to perform the estimate of a radial velocity from a spectrum for flux calibration work in the 2DDRP pipeline. The draft code is based on the study in PIPE2D-649 (https://pfspipe.ipmu.jp/jira/browse/PIPE2D-649). The radial velocity is estimated by taking a cross-correlation between a spectrum and a model template.



 Comments   
Comment by sogo.mineo [ 16/Sep/21 ]

Because I have been working on this task for all too long a time, I provisionally pushed my current codes as tickets/PIPE2D-871. The test code does not pass due to immense systematic errors. I think I should make my own changes in the current algorithm, which had been passed to me and had undergone corrections of only obvious mistakes. That will take some time.

Comment by sogo.mineo [ 17/Sep/21 ]

Test passed. The problem turned out to be the too narrow sampling interval of the cross correlation function, for neighboring samples made from too similar linear-combinations of random variables, or observed spectrum, cause their covariance matrix almost defective, troubling scipy.optimize.curve_fit(), resulting in strange output. I'm making PR.

Comment by sogo.mineo [ 17/Sep/21 ]

Could you review the pull request?

Comment by sogo.mineo [ 29/Sep/21 ]

Thank you for the review. I merged this branch to master.

Generated at Sat Feb 10 15:59:11 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.