[PIPE2D-868] SpectrumSet.makeImage asserts len(self) == len(fiberTraces) which fails with broken fibres Created: 02/Jul/21  Updated: 02/Jul/21  Resolved: 02/Jul/21

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Normal
Reporter: rhl Assignee: rhl
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Reviewers: price

 Description   

SpectrumSet.makeImage asserts that the number of fibres in the DetectorMap and the FiberTraceSet is the same.  This isn't true when there are broken fibres, and
the assertion doesn't seem to be needed to make the book-keeping work. Please remove it.

The alternative is to add dummy traces to fiberTraces but I don't think we need to do that.



 Comments   
Comment by rhl [ 02/Jul/21 ]

https://github.com/Subaru-PFS/drp_stella/pull/205

Comment by rhl [ 02/Jul/21 ]

Merged and pushed

Generated at Sat Feb 10 15:59:07 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.