fluxCalibrationFlow_20210525.pdf
fluxCalibrationFlow_20210607.pdf
[PIPE2D-846] Draw the skeleton of the code integration for the flux calibration Created: 25/May/21 Updated: 29/Jan/22 Resolved: 16/Jun/21 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | Takuji Yamashita | Assignee: | Takuji Yamashita |
| Resolution: | Done | Votes: | 0 |
| Labels: | flux-calibration | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
fluxCalibrationFlow_20210525.pdf
fluxCalibrationFlow_20210607.pdf
|
| Epic Link: | flux calibration |
| Reviewers: | price |
| Description |
|
Make a skeleton of the flux calibration code in the pipeline based on the current codes (calculateReferenceFlux and fluxCalibrate) and a set of the codes in the flux calibration studies. The document of the skeleton will be provided. The attached file (fluxCalibrationFlow_20210525.pdf) is a current rough draft. In this version, the framework (or the process flow) in the existing codes in the pipeline is not considered yet. This task is addressed with the help of Mineo-san. |
| Comments |
| Comment by Takuji Yamashita [ 07/Jun/21 ] |
|
Here is an updated process flow of the flux calibration. fluxCalibrationFlow_20210607.pdf
The blue part is a set of tasks to find the best fit model of a flux standard, while the yellow is to apply the flux calibration to a science target. In the current pipeline, the main processes are done in fitReference.py and measureFluxCalibration.py. They are now placeholders. Individual tasks (square boxes in the flow chart) will be written either in fitReference.py or measureFluxCalibration.py. The naming is tentative.
|
| Comment by Takuji Yamashita [ 11/Jun/21 ] |
|
Does the updated flow chart include enough information to share the code integration concept and to be reviewed for you? We can discuss something about writing here with Mineo-san or do that when we need. |
| Comment by price [ 11/Jun/21 ] |
|
It looks very reasonable. |
| Comment by sogo.mineo [ 11/Jun/21 ] |
|
The flowcharts are enough to start writing codes. Should we directly modify the classes in drp_stella, or make subclasses to implement the flowcharts? In the latter case, should we add files to drp_stella or obs_pfs? If these codes work only for PFS (I don't know whether or not), will it still be OK for these codes to reside in drp_stella? |
| Comment by price [ 11/Jun/21 ] |
|
I think you should start by subclassing. We can clobber the current code once you've demonstrated that it works on the simulated data. |
| Comment by Takuji Yamashita [ 16/Jun/21 ] |
|
Could you review the skeleton (fluxCalibrationFlow_20210607.pdf) of the flux calibration integration? |
| Comment by price [ 16/Jun/21 ] |
|
I reviewed it previously, and it looks good. |
| Comment by Takuji Yamashita [ 16/Jun/21 ] |
|
Thanks for your review. We close this ticket. |
