[PIPE2D-843] Persist headerFix edits in common repo. Created: 19/May/21 Updated: 29/Jan/22 Resolved: 05/Aug/21 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | cloomis | Assignee: | price |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Reviewers: | hassan |
| Description |
|
The headerFix mechanism captures essential fixes to the raw data. A few fixes are in code, in obs/pfs/headerFixes.py. The rest are in data files. Those should be accreted into some instrument-wide repo so they get applied everywhere. [ LAM is as I write taking sm3 data using r2. At the very least there will be W_PFDSGN fixes. ] |
| Comments |
| Comment by cloomis [ 20/May/21 ] |
|
Right now we have yaml files in $OBS_PFS_DIR/corrections at Princeton. The filenames are PFS-$visit.yaml. The files are not checked in. We probably want per-site directories in some instdata product, since LAM visits are not independent of Subaru visits. Arguable. Oh, should the files actually be PFS-$visit-$arm.yaml? |
| Comment by price [ 21/May/21 ] |
|
The authoritative source for header fixes is in the code, from which the yaml files are generated. Should we just move headerFixes.py to pfs_utils? Then you can add whatever interface you need for other work. |
| Comment by price [ 29/Jul/21 ] |
|
Asking hassan to review the code, and cloomis to check that this solution works for him. |
| Comment by hassan [ 29/Jul/21 ] |
|
Code changes look fine to me. As Paul mentions, Craig needs to verify the solution works. |
| Comment by price [ 05/Aug/21 ] |
|
cloomis noted that the current solution doesn't work in general because we have multiple sites with independent visit counters. However, I'm going to merge this because it's the current solution (this ticket merely moves where that solution lives, making the limited solution available to more parties which is potentially a good thing), and leave it to wiser heads than mine to decide if and when we need a more complete solution. |
| Comment by price [ 05/Aug/21 ] |
|
Merged. |