[PIPE2D-826] Update detectorMap to add all fibers really present in a slit Created: 28/Apr/21  Updated: 30/Apr/21  Resolved: 30/Apr/21

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: fmadec Assignee: price
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Story Points: 2
Sprint: 2DDRP-2021 A 4
Reviewers: hassan

 Description   

It appears that even if there not used, 3 slit have 600 fibers instead of 2.

DetectorMap should be updated according. The pfsConfig then tells you what the fibres are used for (or if they're broken, or unassigned, or ...)

 

see INSTRM-1195

and https://pfs.ipmu.jp/internal/bts/show_bug.cgi?id=863

 Comments   
Comment by price [ 28/Apr/21 ]

Currently:

>>> for xx in product("brnm", "1234"):
...     detMap = DetectorMap.readFits(f"drp_pfs_data/detectorMap/detectorMap-sim-{''.join(xx)}.fits")
...     print(xx, detMap.fiberId.min(), detMap.fiberId.max(), detMap.fiberId.size)
... 
('b', '1') 2 650 600
('b', '2') 653 1301 600
('b', '3') 1304 1952 597
('b', '4') 1955 2603 597
('r', '1') 2 650 600
('r', '2') 653 1301 600
('r', '3') 1304 1952 597
('r', '4') 1955 2603 597
('n', '1') 2 650 600
('n', '2') 653 1301 600
('n', '3') 1304 1952 597
('n', '4') 1955 2603 597
('m', '1') 2 650 600
('m', '2') 653 1301 600
('m', '3') 1304 1952 597
('m', '4') 1955 2603 597
Comment by hassan [ 28/Apr/21 ]

See also https://sumire.pbworks.com/w/file/fetch/142768458/fiber_routing_YMoritani_20210110.pdf
SM2 consists of 597 fibres, the rest 600.

Comment by price [ 28/Apr/21 ]

Added all fiber holes to all detectorMaps. The pfsConfig will tell us which are illuminated.

Comment by price [ 28/Apr/21 ]

Demonstrating that the new detectorMaps contain all (science) fiber holes:

>>> from itertools import product
>>> from pfs.drp.stella import DetectorMap
>>> for xx in product("brnm", "1234"):
...     detMap = DetectorMap.readFits(f"detectorMap-sim-{''.join(xx)}.fits")
...     print(xx, detMap.fiberId.min(), detMap.fiberId.max(), detMap.fiberId.size)
... 
('b', '1') 2 650 600
('b', '2') 653 1301 600
('b', '3') 1304 1952 600
('b', '4') 1955 2603 600
('r', '1') 2 650 600
('r', '2') 653 1301 600
('r', '3') 1304 1952 600
('r', '4') 1955 2603 600
('n', '1') 2 650 600
('n', '2') 653 1301 600
('n', '3') 1304 1952 600
('n', '4') 1955 2603 600
('m', '1') 2 650 600
('m', '2') 653 1301 600
('m', '3') 1304 1952 600
('m', '4') 1955 2603 600
Comment by hassan [ 28/Apr/21 ]

Looks fine. See minor comment about docString.

Comment by price [ 30/Apr/21 ]

Cleaned up and merged.

Generated at Sat Feb 10 15:58:31 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.