[PIPE2D-822] Weekly broken by non-finite wavelength residuals Created: 27/Apr/21 Updated: 27/Apr/21 Resolved: 27/Apr/21 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | price | Assignee: | price |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Sprint: | 2DDRP-2021 A 4 |
| Reviewers: | hassan |
| Description |
|
The 2021-04-25 weekly broke: ====================================================================== FAIL: testResiduals (__main__.ArcTestCase_brn_39) (arm='b', fiberId=2) Test that wavelength fit residuals are reasonable ---------------------------------------------------------------------- Traceback (most recent call last): File "/scratch/pprice/jenkins/weekly/2021-04-25/build/stack/miniconda3-4.5.12-1172c30/Linux64/pfs_pipe2d/w.2021.17/python/pfs/pipe2d/weekly/test_weekly.py", line 126, in testResiduals self.assertFloatsAlmostEqual(median, 0.0, atol=2.0e-2) File "/scratch/pprice/jenkins/weekly/2021-04-25/build/stack/miniconda3-4.5.12-1172c30/Linux64/utils/18.1.0/python/lsst/utils/tests.py", line 668, in assertFloatsAlmostEqual testCase.fail("Non-finite values in lhs") AssertionError: Non-finite values in lhs |
| Comments |
| Comment by price [ 27/Apr/21 ] |
|
We now get all lines in the arcLines data product, not just the good ones, so we need to filter the list. |
| Comment by hassan [ 27/Apr/21 ] |
|
Reviewed. No problems with proposed changes. |
| Comment by price [ 27/Apr/21 ] |
|
Merged. |