[PIPE2D-819] fiberProfiles should contain an entry for every fibre in pfsConfig for that spectrograph Created: 24/Apr/21  Updated: 29/Jan/22  Resolved: 27/Apr/21

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Normal
Reporter: rhl Assignee: Unassigned
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to PIPE2D-890 fiberProfileSet does not return the e... Open

 Description   

Currently the FiberTraceSet returned by butler.get("fiberTraces", ...) omits broken fibres, so e.g. for SuNSS it contains 251 not 254 entries. This means that it lines up neither with pfsConfig[pfsConfig.spectrograph == n] (using post-PIPE2D-770 syntax) nor with pfsArm/pfsMerged files.

Please fix this, and carry out an audit for any other data products that don't have an entry for every fibre.

In the short run, the "solution" is

pfsConfig = butler.get("pfsConfig", dataId) 
fiberProfiles = butler.get("fiberProfiles", dataId)
fid0 = fiberProfiles.fiberId[0]
for fid in set(pfsConfig.fiberId) - set(fiberProfiles.fiberId):
    fiberProfiles[fid] = fiberProfiles[fid0]


 Comments   
Comment by rhl [ 27/Apr/21 ]

Merged and pushed

Generated at Sat Feb 10 15:58:27 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.