[PIPE2D-814] Update the SM1 gains Created: 17/Apr/21 Updated: 19/Apr/21 Resolved: 19/Apr/21 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | rhl | Assignee: | rhl |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Sprint: | 2DDRP-2021 A 4 |
| Reviewers: | hassan |
| Description |
|
the quoted SM1 gains aren't quite right, we (i.e. arnaud.lefur) think that better values are:
gains = dict(b=np.array([1.32, 1.31, 1.34, 1.26, 1.36, 1.31, 1.34, 1.26]),
r=np.array([1.181009, 1.169722, 1.174006, 1.196543, 1.250177, 1.259089, 1.247757, 1.207198]),
rold=np.array([1.24, 1.24, 1.27, 1.18, 1.26, 1.20, 1.24, 1.26]),
)
where "rold" are the current values that we're using for both the r and b arms. Please update obs_pfs. In the longer term (Gen3) this will be in a pure-data product, but for now please just use the old mechanism. |
| Comments |
| Comment by rhl [ 19/Apr/21 ] |
|
It turns out that someone called "RHL" set the parallel overscan to have zero width. Please fix that at the same time. |
| Comment by rhl [ 19/Apr/21 ] |
|
We may need to revisit this when we have new readnoise/gain values, but I needed to get the parallel overscan fix in and these values are better than the current placeholders (especially in b) https://github.com/Subaru-PFS/obs_pfs/pull/98
|
| Comment by hassan [ 19/Apr/21 ] |
|
All changes look fine. No additional comments. |
| Comment by rhl [ 19/Apr/21 ] |
|
Merged and pushed |