[PIPE2D-812] makeDummyCableBDesign.py should include fiberIds for all spectrographs Created: 16/Apr/21 Updated: 18/Apr/21 Resolved: 17/Apr/21 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | price | Assignee: | price |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Story Points: | 1 |
| Sprint: | 2DDRP-2021 A 4 |
| Reviewers: | hassan |
| Description |
|
Our detectorMaps have the proper fiberId values, but makeDummyCableBDesign.py produces fiberId values suitable only for spectrograph=1. We need to be able to support the other spectrographs. This was revealed by errors when running bootstrapDetectorMap.py. |
| Comments |
| Comment by price [ 17/Apr/21 ] |
|
Got bootstrap working on b3: bootstrapDetectorMap.py /projects/HSC/PFS/LAM --calib=/scratch/pprice/pipe2d-812/calib --rerun price/pipe2d-812/bootstrap --flatId visit=24678 arm=b --arcId visit=24681 arm=b -c spatialOrder=1 spectralOrder=1 isr.doFlat=False [...] bootstrap INFO: Median difference from detectorMap: 9.255192,-7.397537 pixels bootstrap INFO: Fit 15/24 points, rms: x=0.034556 y=0.037018 total=0.023493 pixels bootstrap INFO: Median difference from detectorMap: 5.965143,-8.337619 pixels bootstrap INFO: Fit 9/18 points, rms: x=0.003696 y=0.024012 total=0.012350 pixels |
| Comment by hassan [ 17/Apr/21 ] |
|
All changes look good to me. |
| Comment by price [ 17/Apr/21 ] |
|
Merged. |