[PIPE2D-810] Allow the user to specify a pfsConfig file to be used by mergeArms Created: 14/Apr/21 Updated: 19/Apr/21 Resolved: 19/Apr/21 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | rhl | Assignee: | rhl |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Sprint: | 2DDRP-2021 A 4 |
| Reviewers: | price |
| Description |
|
When processing SuNSS data it would be very useful to be able to specify my own pfsConfig file, which defines SKY and SCIENCE fibres. Please add a configuration option to make this possible. We may need this for other pipelines too, but let's start here. |
| Comments |
| Comment by rhl [ 14/Apr/21 ] |
|
I don't much like using PfsConfig._readImpl, but I don't see an easy way around it. We might want to file a ticket to fix this, but as this is really a debugging/commissioning option maybe it's not worth it? I suspect that we'll use this for PFI as well as SuNSS. |
| Comment by rhl [ 14/Apr/21 ] |
|
Moving back to InProgress while I decide if I need to add this to mergeArms now rather than later. |
| Comment by rhl [ 18/Apr/21 ] |
| Comment by hassan [ 19/Apr/21 ] |
|
Changes look OK, but how are the default values of designId and visit0 handled? Is there a corresponding PfsDesign file present somewhere? |
| Comment by rhl [ 19/Apr/21 ] |
|
Responded to comments and merged to master |