[PIPE2D-806] Implement misalignment in 2d psf algorithm Created: 08/Apr/21 Updated: 13/Apr/21 Due: 08/Apr/21 Resolved: 13/Apr/21 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | ncaplar | Assignee: | ncaplar |
| Resolution: | Done | Votes: | 0 |
| Labels: | illumination | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||
| Issue Links: |
|
||||||||
| Story Points: | 1 | ||||||||
| Sprint: | 2DDRP-2021 A 4 | ||||||||
| Description |
|
The task is to implement misalignment in the 2d psf algorithm, primarily to be used for testing PIPE2D-623 by Brent Belland. The class that implements illumination has already been provided previously by Brent Belland so this could be relative simple implementation at this stage. |
| Comments |
| Comment by ncaplar [ 09/Apr/21 ] |
|
Brent Belland please consult the new version of the algorithm at github (https://github.com/Subaru-PFS/dev_2ddrp/tree/master/2d_PSF_code). The parameters, if you are using Zernike up to 22 are: 'z4', 'z5', 'z6', 'z7', 'z8', 'z9', 'z10', 'z11', 'z12', 'z13', 'z14', 'z15', 'z16', 'z17', 'z18', 'z19', 'z20', 'z21', 'z22', 'hscFrac', 'strutFrac', 'dxFocal', 'dyFocal', 'slitFrac', 'slitFrac_dy', 'wide_0', 'wide_23', 'wide_43', 'misalign', 'x_fiber', 'y_fiber', 'effective_radius_illumination', 'frd_sigma', 'frd_lorentz_factor', 'det_vert', 'slitHolder_frac_dx', 'grating_lines', 'scattering_slope', 'scattering_amplitude', 'pixel_effect', 'fiber_r', 'flux' Note the new parameters wide_0, wide_23, wide_43 and misalign. You can use old parameters, but set wide_0, wide_23 and wide_43 to 0. Misalign is the parameters that control amount of misalignment (as shown in the Figure). Perhaps it would be beneficial if you would switch to using updated parameters for psf solutions which would be more accurate and which were done with these parameters choices. Let's talk about this tomorrow. If you are eager to start working on that before our normal meeting time at 4.30pm at East Coast, send me a msg on Slack. |
| Comment by ncaplar [ 09/Apr/21 ] |
|
I will keep this open for a moment until we assure that complete transfer of information between Brent and I has been achived. |