[PIPE2D-804] Simplify the broken-shutter analytic-corrections code Created: 02/Apr/21  Updated: 03/Apr/21  Resolved: 03/Apr/21

Status: Done
Project: DRP 2-D Pipeline
Component/s: obs_pfs
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Normal
Reporter: rhl Assignee: rhl
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Reviewers: hassan

 Description   

The current broken shutter code has two modes, reading and subtracting a bias and using an analytical model of the readout. The former has not been extensively used and is a nuisance as it cannot fit cleanly in the IsrTask as it has to hunt for a suitable bias exposure taken close to the data frame. The latter appears to work well.
We expect to replace the shutter within a few days, but I am not convinced that the problem won't reappear in the future; additionally the analytic version can be used from notebooks to produce a fast reduction on the mountain for e.g. "IFU images".
Please move the analytic code into the Task proper; we can postpone the possible removal of the bias-based code to another time.



 Comments   
Comment by rhl [ 02/Apr/21 ]

https://github.com/Subaru-PFS/obs_pfs/pull/96

Comment by hassan [ 02/Apr/21 ]

Changes look fine. Only minor comments on docString and replacing certain print calls with logging calls. But these can be deferred to a later ticket if these changes need to be put into master promptly.

Comment by rhl [ 03/Apr/21 ]

I didn't formally put it up for review yet, but thanks! I responded to your comments, merged to master, and pushed.

Generated at Sat Feb 10 15:58:16 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.