[PIPE2D-802] w.2021.13 breaks DetectorMap interaction with 2d sky-subtracted images Created: 31/Mar/21 Updated: 02/Apr/21 Resolved: 02/Apr/21 |
|
| Status: | Won't Fix |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Major |
| Reporter: | ncaplar | Assignee: | price |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Story Points: | 1 |
| Sprint: | 2DDRP-2021 A3 |
| Description |
|
As discussed on weekly Princeton PFS telecom on March 29, weekly on Tiger (w.2021.13) breaks the interaction between sky 2d subtracted images and DetectorMap. For example:
butler_subtracted = dafPersist.Butler("/projects/HSC/PFS/Subaru/rerun/ncaplar/PIPE2D-490_Mar1_2021_skyTrue",\ calibRoot='/projects/HSC/PFS/Subaru/CALIB-ncaplar') exposure_subtracted= butler_subtracted.get("calexp", visit=34444, arm="r", spectrograph=1)
fails with Exception: File "src/GlobalDetectorModel.cc", line 355, in virtual std::shared_ptr<lsst::afw::table::io::Persistable> pfs::drp::stella::GlobalDetectorModel::Factory::read(const lsst::afw::table::io::InputArchive&, const lsst::afw::table::io::CatalogVector&) const Archive assertion failed: record.getSchema() == schema.schema {0} File "src/table/io/InputArchive.cc", line 104, in std::shared_ptr<lsst::afw::table::io::Persistable> lsst::afw::table::io::InputArchive::Impl::get(int, const lsst::afw::table::io::InputArchive&) loading object with id=1205, name='GlobalDetectorModel' {1} File "src/table/io/InputArchive.cc", line 104, in std::shared_ptr<lsst::afw::table::io::Persistable> lsst::afw::table::io::InputArchive::Impl::get(int, const lsst::afw::table::io::InputArchive&) loading object with id=2, name='DifferentialDetectorMap' {2} File "src/table/io/InputArchive.cc", line 104, in std::shared_ptr<lsst::afw::table::io::Persistable> lsst::afw::table::io::InputArchive::Impl::get(int, const lsst::afw::table::io::InputArchive&) loading object with id=1, name='NevenPsf' {3} lsst::afw::table::io::MalformedArchiveError: 'Archive assertion failed: record.getSchema() == schema.schema {0}; loading object with id=1205, name='GlobalDetectorModel' {1}; loading object with id=2, name='DifferentialDetectorMap' {2}; loading object with id=1, name='NevenPsf' {3}'
|
| Comments |
| Comment by price [ 02/Apr/21 ] |
|
The archive persistence code changed. Do we need to be able to read old archive-persisted PFSes, or can you simply regenerate them? |
| Comment by ncaplar [ 02/Apr/21 ] |
|
Jup, I can regenerate. During Monday meeting when we were triaging the problem, we though this might be more serious. I suggest placing it as `Wont Fix' and I will open new tickets if there are any future problems. |
| Comment by price [ 02/Apr/21 ] |
|
OK, thanks. I'm sorry I didn't think to add in some backwards compatibility when I made this change. I can fix that now if you like, but it sounds like it's not worth the trouble. |
| Comment by hassan [ 02/Apr/21 ] |
|
OK, following Neven's comment, marking this as 'Wont Fix'. |