[PIPE2D-798] Improve provenance for detectorMaps Created: 27/Mar/21 Updated: 30/Sep/21 Resolved: 30/Sep/21 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | rhl | Assignee: | price |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Story Points: | 1 |
| Sprint: | 2DDRP-2021 A3, 2DDRP-2021 A 8, 2DDRP-2021 A 9 |
| Reviewers: | hassan |
| Description |
|
Please improve the provenance for DetectorMaps to at least the level provided by FiberProfiles (CALIB_CREATION_DATE/CALIB_CREATION_TIME/CALIB_INPUT_n). Currently I only see: 'DATE-OBS': '2020-01-01T00:00:00', 'CALIB_ID': 'arm=b spectrograph=1 ccd=0 filter=b calibDate=2021-03-06 calibTime=2021-03-06T16:29:31.941 visit0=46270', 'MINX': 0, 'MINY': 0, 'MAXX': 4095, 'MAXY': 4175, 'OBSTYPE': 'detectorMap', 'pfs_detectorMap_class': 'DifferentialDetectorMap', 'DAMD_VER': 1, 'SCALING.fiberPitch': 5.995148184351668, 'SCALING.dispersion': 0.06665265298226958, 'SCALING.wavelengthCenter': 519.427358946762, 'SCALING.minFiberId': 2.0, 'SCALING.maxFiberId': 650.0, 'SCALING.height': 4176.0, 'SCALING.buffer': 0.05000000074505806, 'ORDER': 4, 'FIBERCENTER': 326.0 For comparison: 'OBSTYPE': 'fiberProfiles', 'calibDate': '2021-03-06', 'CALIB_CREATION_DATE': '2021-03-19', 'CALIB_CREATION_TIME': '17:06:55 EDT', 'CALIB_INPUT_0': '(46241,)', 'CALIB_INPUT_1': '(46242,)', 'CALIB_INPUT_2': '(46243,)', 'CALIB_INPUT_3': '(46244,)', 'CALIB_INPUT_4': '(46245,)', 'CALIB_INPUT_5': '(46246,)', 'CALIB_INPUT_6': '(46247,)', 'CALIB_INPUT_7': '(46248,)', 'CALIB_INPUT_8': '(46249,)', 'CALIB_INPUT_9': '(46250,)', 'CALIB_ID': 'arm=b spectrograph=1 ccd=0 filter=None calibTime=2021-03-06T15:19:14.092049152 visit0=46241 calibDate=2021-03-06', 'MD5': '889a8a73a4b01fd7504461eb6ef479a5', 'SPECTROGRAPH': 1, 'ARM': 'b', 'DAMD_VER': 1 |
| Comments |
| Comment by price [ 27/Mar/21 ] |
|
Not sure whether the HISTORY cards are getting stripped, or you're looking at an old detectorMap. The header of /projects/HSC/PFS/Subaru/CALIB-SuNSS-new/DETECTORMAP/pfsDetectorMap-046272-r1.fits includes: HISTORY reduceArc on 2021-03-26T13:04:46.848303 with visit=46272,46273,46274,462 HISTORY 75,46276,46277 |
| Comment by rhl [ 27/Mar/21 ] |
|
I'm looking at the detectorMap.metadata. But history cards are not acceptable — note for example that the visit 46275 is split between two lines and who knows what else will go into history? The provenance needs to be uniform, and the way that it's done with fiberProfile is the current de-facto standard. |
| Comment by hassan [ 29/Sep/21 ] |
|
Changes look fine to me. I wonder whether configuration parameters should also be included in the provenance information stored, but that is a separate discussion. |
| Comment by price [ 29/Sep/21 ] |
|
Configuration parameters are stored by the butler in a separate file. |
| Comment by price [ 30/Sep/21 ] |
|
Merged. |