[PIPE2D-768] Add the ability to list a set of arc line files Created: 10/Mar/21  Updated: 11/Mar/21  Resolved: 11/Mar/21

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Normal
Reporter: rhl Assignee: rhl
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Sprint: 2DDRP-2021 A3
Reviewers: price

 Description   

This will allow me to use dome light (== Hg + Ar) + sky (OI, Na) to solve for SuNSS.  

We should also split the monolithic ArCdHgKrNeXe.txt file but that's a different ticket (e.g. we need ArHg.txt separately from Ar.txt as the blends are different, and the broadened lines that we don't want to use are only in the former)



 Comments   
Comment by price [ 11/Mar/21 ]

I suggest waiting until after PIPE2D-557 before tackling this.

Comment by rhl [ 11/Mar/21 ]

What's your concern?  I think that the changes are orthogonal

Comment by price [ 11/Mar/21 ]

I'd like to do some refactoring as part of PIPE2D-557 (create ReferenceLine class, move the readLineList function into there).

Comment by rhl [ 11/Mar/21 ]

Well, as I did the work for the "dome arc" + sky data, is it OK to merge (i.e. ask for a review) and you can take the refactoring from there?

Comment by price [ 11/Mar/21 ]

Oh, if you're done already then let's get this merged!

Comment by rhl [ 11/Mar/21 ]

https://github.com/Subaru-PFS/drp_stella/pull/170

Comment by rhl [ 11/Mar/21 ]

rebased and merged to master

Generated at Sat Feb 10 15:57:30 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.