[PIPE2D-765] Stop generating one "Matched N1 from N2 observed and N3 reference lines" line for every fibre Created: 08/Mar/21  Updated: 09/Mar/21  Resolved: 09/Mar/21

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Normal
Reporter: rhl Assignee: rhl
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Sprint: 2DDRP-2021 A3
Reviewers: price

 Description   

it's bearable with the DCB, but not SuNSS or PFS!

 



 Comments   
Comment by rhl [ 08/Mar/21 ]

https://github.com/Subaru-PFS/drp_stella/pull/164

Comment by rhl [ 09/Mar/21 ]

Plus a critical missing line:  commit 0608b7d

Oops, typo.  Ignore me

Comment by rhl [ 09/Mar/21 ]

As you were.  The line I thought was missing wasn't (I'd changed the match radius and it mimicked this problem), so I reverted the commit. That PR's good, and I see that Hassan already approved it (thanks!)

Comment by rhl [ 09/Mar/21 ]

rebased and merged to master

Generated at Sat Feb 10 15:57:28 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.