[PIPE2D-748] Do not fiddle with slit offsets by default in reduceArc Created: 03/Mar/21 Updated: 06/Mar/21 Resolved: 06/Mar/21 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | rhl | Assignee: | rhl |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Sprint: | 2DDRP-2021 A3 |
| Reviewers: | price |
| Description |
|
The default value of config.reduceExposure.doOffsetDetectorMap for reduceArc is True; please change this to False. The slit offsets are a feature of the hardware, resulting from exactly how we epoxy the fibres into the slit at LNA. We should therefore only change them after very careful analysis, and certainly not every time that we update the arc solution. In particular, allowing the offsets to float causes running reduceArc on SuNSS arc data to miss real fibres moderately often. By turning this off, all 195 sky frames that I looked ran successfully in both b and r. |
| Comments |
| Comment by rhl [ 05/Mar/21 ] |
|
It turns out that FitDifferentialDetectorMapTask doesn't obey config.doSlitOffsets, so fix that too |
| Comment by rhl [ 05/Mar/21 ] |
| Comment by rhl [ 06/Mar/21 ] |
|
rebased, merged, and pushed |