[PIPE2D-744] Fix the model used for analytical correction of red shutter problems Created: 01/Mar/21 Updated: 01/Mar/21 Resolved: 01/Mar/21 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | obs_pfs |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | rhl | Assignee: | rhl |
| Resolution: | Done | Votes: | 0 |
| Labels: | SuNSS | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Reviewers: | hassan |
| Description |
|
I was foolish and deluded. The wipe results in all the light redder than the pixel being included. I used the mean for the wipe model, and in conjunction with the all light bluer from the read the model was flexible enough to work, but with the wrong times for the coefficients. Fix the code to use the proper model, and update the coefficients to be physical interpretable. While we're about it, set the variance correctly when using the analytical correction; and don't try to correct biases. |
| Comments |
| Comment by rhl [ 01/Mar/21 ] |
| Comment by hassan [ 01/Mar/21 ] |
|
Minor flake8 violation needs to be corrected, but otherwise can be merged to master. |