[PIPE2D-739] mergeArms doesn't handle broken fibres in mergeLsfs Created: 25/Feb/21  Updated: 27/Feb/21  Resolved: 27/Feb/21

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Story Priority: Normal
Reporter: rhl Assignee: rhl
Resolution: Done Votes: 0
Labels: SuNSS
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Sprint: 2DDRP-2021 A 2
Reviewers: price

 Description   

Now that pfsArms have broken fibres (PIPE2D-720), the assumption in mergeLsfs that assumes that all fiberIds are in warpLsf is invalid.
It is not obvious that the obvious fix of checking for the presence of the fibre is correct, or whether the problem should be pushed upstream. It's also not possible to check that the problem is indeed a broken fibre as pfsConfig isn't available

 Comments   
Comment by rhl [ 25/Feb/21 ]

The quick fix is

for ii in range(len(spectra)):
    ff = spectra.fiberId[ii]
    warpedLsf[ff] = warpLsf(lsf[ff], spectra.wavelength[ii], wavelength) if ff in lsf else None
Comment by rhl [ 26/Feb/21 ]

Actually, let's get the hack merged and then think about doing this properly later

Comment by rhl [ 26/Feb/21 ]

PR https://github.com/Subaru-PFS/drp_stella/pull/152

Comment by hassan [ 27/Feb/21 ]

Approved by me, but may need a check by price.

Comment by hassan [ 27/Feb/21 ]

Review complete to move this fix promptly to master.

Generated at Sat Feb 10 15:57:11 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.