[PIPE2D-721] pfs_build_calibs routine, combineFiberProfiles, basename missing Created: 16/Feb/21  Updated: 17/Feb/21  Resolved: 17/Feb/21

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: ncaplar Assignee: Unassigned
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Blocks
blocks PIPE2D-671 Analyze Subaru images and create a 2d... Done
Sprint: 2DDRP-2021 A 2

 Description   

I have been stuck for quite a while on combineFiberProfiles.py step, following the pfs_build_calibs routine.  The relevant part of the error is here: https://gist.github.com/nevencaplar/1c90d31a30abb1ce1b957caa54bc6c08It seems to me that the error is due to basename: missing operand  statement. Because this is newer part of procedure that I have never seen before I can not gronk what is happening and be more helpful (sorry). I have been looking into integration test where this error does not occur, but it is not obvious to me where does basename comes from and what is happening exactly. I have tried by passing only one image for fiberprofile, or two (as in this example above) but got the same result.

hassan  comments: I think the error is as you say a missing argument to basename. I'm guessing @paulprice there is a bug in pfs_build_calibs.sh here: https://github.com/Subaru-PFS/pfs_pipe2d/blob/1287ee8659bd4754da2e2997d721060ad8fa271b/bin/pfs_build_calibs.sh#L153 where the argument traces doesn't seem to exist. I guess that should have been changed to profiles looking at the last change. But I'm not 100% sure, as the last integration test was successful..

Paul comments: Traces should have been replaced by profiles throughout. It’s possible I missed something because we’re not using that script any more (replaced by the YAML files)

 

I am opening this ticket in order to decide on how to proceed. 



 Comments   
Comment by ncaplar [ 17/Feb/21 ]

The errors were due to the fact that some `FiberTrace` syntax has not been translated to `FiberProfile` syntax. This has been fixed and made consistent.

Generated at Sat Feb 10 15:56:54 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.