[PIPE2D-720] Include broken fibres in pfsArm/pfsMerged files Created: 15/Feb/21 Updated: 20/Feb/21 Resolved: 20/Feb/21 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | rhl | Assignee: | price |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Sprint: | 2DDRP-2021 A 2 |
| Reviewers: | hassan |
| Description |
|
Currently only fibres that are found in the data are included in the extractions, but it's a nuisance for the pfsConfig and pfsArm/merged files to have slightly different fibreIds when there are broken fibres (e.g. SuNSS) Please include all the fibres in the pfsConfig when writing outputs; the values should all be `NaN`. |
| Comments |
| Comment by price [ 19/Feb/21 ] |
|
Changed the ExtractSpectraTask to support this. Note that for spectrographs other than SM1, there's no way for the indices of fiberId arrays in pfsConfig and the extracted spectra to match up. |
| Comment by price [ 19/Feb/21 ] |
|
Broke the integration test: NAN wavelength arrays are non-monotonic. |
| Comment by rhl [ 19/Feb/21 ] |
|
Good point on SM1, but the other spectrographs are simply offset by 600*n. Well, they should be (we have to allow for 2394 != 2400) |
| Comment by price [ 20/Feb/21 ] |
|
Passes integration test now. |
| Comment by price [ 20/Feb/21 ] |
|
Merged to master. |