[PIPE2D-714] Update extra-pixel correction logic in PfsMapper:std_raw() Created: 13/Feb/21 Updated: 17/Feb/21 Resolved: 17/Feb/21 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | obs_pfs |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | cloomis | Assignee: | cloomis |
| Resolution: | Done | Votes: | 0 |
| Labels: | SuNSS | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Story Points: | 2 |
| Sprint: | 2DDRP-2021 A 2 |
| Reviewers: | hassan |
| Description |
|
Earlier versions of the CCD DAQs generate an extra pixel at the start of each amp's readout. This shifts all subsequent pixels from that amp over by one. It manifests as a shifted column, but is just a shifted pixel. The std_raw routine optionally applies a correction for that effect, based on the existence or value of a now obsolete header card. For recent data, this correction is being applied when it shouldn't be. Retrace the history of the issue and rephrase the logic in PfsMapper.py to apply the correction only when it should be. |
| Comments |
| Comment by rhl [ 17/Feb/21 ] |
|
The code ran the extra-pixel fix if W_VERSIONS_FPGA isn't present in the header (which it is not at MKO); changed the logic to only fix data which is known to have an old FPGA version. |