[PIPE2D-699] Rerun 2d-psf analysis for spots with neighbors Created: 20/Jan/21  Updated: 09/Feb/21  Resolved: 26/Jan/21

Status: Done
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Normal
Reporter: ncaplar Assignee: ncaplar
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File example_of_problem.png    
Story Points: 2

 Description   

During analysis of data with the code that keeps illumination consistent as a function of defocus (PIPE2D-671), some (all?) spots which have neighbors did not get properly analyzed (see Figure). 

Identify the problem, fix and rerun this part of analysis. 



 Comments   
Comment by ncaplar [ 26/Jan/21 ]

I seem to have identified the problem. The issue was in using floats in Psf_position.fill_crop function, within Zerike_Module. The floats can not be used at slices, and the issues is resolved when using integers. I am not sure why did this work before (probably a change when updating python versions?).

While working on this problem I have discovered that some values identifying how parameters of ``secondary images'' are connected to the primary image (i.e., the offset and the strength of the second spot present) were wrong for Argon spots. I have corrected that. 

 

Comment by ncaplar [ 09/Feb/21 ]

I also discovered that at the subpixel level, x and y coordinates were mixed. I have fixed that for future iterations of the code.

Generated at Sat Feb 10 15:56:40 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.