[PIPE2D-69] tests/testDrp.py fails without returning an error code on os/x 10.11 Created: 18/Aug/16 Updated: 13/Jun/17 Resolved: 13/Jun/17 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Major |
| Reporter: | aritter | Assignee: | aritter |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Sprint: | 2014-16 | ||||||||
| Reviewers: | swinbank | ||||||||
| Description |
|
tests/testDrp.py fails without returning an error code. It's due to the os/x 10.11 SIP stuff RHL assumes, but the lack of an error code is a bug. Also, not sure that we should be using python unittest to test shell scripts. How does ci_hsc do this? |
| Comments |
| Comment by aritter [ 15/Mar/17 ] |
|
Re RHL's question how ci_hsc does the integration test, that's way more complicated and I haven't got any comments yet from price. RHL said if it works leave it but ask Paul. We might possibly want to change this in the future in another ticket... |
| Comment by swinbank [ 15/Mar/17 ] |
|
I don't remember the context of that question, but I don't think we'd want to follow the ci_hsc approach here: it has plenty of problems of its own. |
| Comment by aritter [ 16/Mar/17 ] |
|
Didn't check before what happens if there is an actual error. Turns out it would still have passed. Fixed that now... |
| Comment by swinbank [ 15/Apr/17 ] |
|
Stealing this review for myself too... |
| Comment by rhl [ 07/Jun/17 ] |
|
I didn't run this to confirm that you do return an error code. If you did check this, good to merge after you deal with the comment. |
| Comment by aritter [ 13/Jun/17 ] |
|
Merged into master |