[PIPE2D-675] detMap.findPoint(fid, wavelength) returns a valid point even if wavelength is not on chip Created: 10/Dec/20 Updated: 11/Dec/20 Resolved: 11/Dec/20 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | rhl | Assignee: | price |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Reviewers: | rhl |
| Description |
|
If I set x, y = detMap.findPoint(fid, lambda) for a wavelength lambda which isn't on the device the returned point lies on the edge of the device (e.g. y = 0). This is a problem, as detMap.bbox.contains(PointI(x, y)) returns True. Please return an invalid point (e.g. one pixel above or below the CCD, or +- Inf) |
| Comments |
| Comment by price [ 10/Dec/20 ] |
|
Which detectorMap class does this? |
| Comment by rhl [ 10/Dec/20 ] |
|
pfs.drp.stella.SplinedDetectorMap.SplinedDetectorMap |
| Comment by price [ 10/Dec/20 ] |
|
Got a fix. rhl, would you please verify that it works for you? |
| Comment by rhl [ 11/Dec/20 ] |
|
I confirmed that this works for me |
| Comment by price [ 11/Dec/20 ] |
|
Merged to master. |