[PIPE2D-668] Support ISR processing for NIR data Created: 05/Dec/20 Updated: 28/Oct/22 Resolved: 16/Oct/22 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | hassan | Assignee: | rhl |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||||||
| Story Points: | 2 | ||||||||||||||||||||||||||||||||
| Sprint: | 2DDRP-2021 A, 2DDRP-2021 A 7, 2DDRP-2021 A12, 2DDRP-2022 A, 2DDRP-2022 E, 2DDRP-2022 F | ||||||||||||||||||||||||||||||||
| Reviewers: | price | ||||||||||||||||||||||||||||||||
| Description |
|
The 2D DRP needs to perform Instrument Signature Removal (ISR) on NIR data. This is a placeholder ticket, to capture this work. Details will be added as comments and related tickets in due course. |
| Comments |
| Comment by hassan [ 14/Jan/22 ] |
|
Waiting on gimbalator data. |
| Comment by hassan [ 18/Aug/22 ] |
|
This can be closed. Need add RHL's report to this prior to closing. Future work will be subject to separate tickets. |
| Comment by hassan [ 18/Aug/22 ] |
|
Report by RHL and C. Loomis that describes the software implemented for this ticket is available here: https://sumire.pbworks.com/w/file/fetch/149867184/princeton-software_NCU1review20220722.pdf |
| Comment by hassan [ 18/Aug/22 ] |
|
In discussions during ICS/DRP+SpS telecon 2022-08-17, ticket considered closed. Report linked. |
| Comment by hassan [ 15/Sep/22 ] |
|
Changes unfortunately not yet committed to master. Ticket subsequently reopened. With Sep 2022 engineering run looming, suggest to delay merging to master till after that run, or at least till the DRP software for the Sep run is tagged. |
| Comment by arnaud.lefur [ 08/Oct/22 ] |
|
Might be the right moment to merge right ? |
| Comment by hassan [ 08/Oct/22 ] |
|
I think so. price? Any comments? |
| Comment by price [ 08/Oct/22 ] |
|
I don't see pull requests. Has this been reviewed? Is it up-to-date with master? |
| Comment by hassan [ 13/Oct/22 ] |
|
Additional changes made to support integration tests and weekly builds. Ready for review. |
| Comment by rhl [ 14/Oct/22 ] |
|
Responded to (almost all) comments. Didn't squash commits, if necessary this could be done tomorrow, but I think that the code and doc changes are there. |
| Comment by hassan [ 16/Oct/22 ] |
|
Integration test passes and local weekly build run. Merged to master. |