[PIPE2D-667] Ensure LSF product is generated as part of pipeline processing Created: 05/Dec/20 Updated: 02/Feb/21 Resolved: 23/Jan/21 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Normal |
| Reporter: | hassan | Assignee: | price |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Story Points: | 2 |
| Sprint: | 2DDRP-2021 A |
| Reviewers: | hassan |
| Description |
|
According to the datamodel.txt, an LSF file should be generated by the pipeline: Presently they do not appear to be. Please ensure that they are. This would be useful for the 1D DRP development team, who are presently using their own independent representation of the LSF. |
| Comments |
| Comment by price [ 05/Dec/20 ] |
|
Currently, the LSF is only generated when we have a 2D PSF, and we only have a 2D PSF for real data. We have proposed to write a Gaussian LSF for the 1D team. Do they have a particular width in mind, or should I invent something? |
| Comment by vlebrun [ 18/Dec/20 ] |
|
why not taking the nominal spectral resolution for the 3 arms ? |
| Comment by price [ 18/Dec/20 ] |
|
OK, so the Gaussian sigma shall be, as a function of arm: |
| Comment by price [ 20/Jan/21 ] |
|
We currently only have a mechanism to produce an LSF for the pfsArm. It will take more effort to generate LSFs for the pfsObject files. Should that be considered part of this ticket? |
| Comment by price [ 20/Jan/21 ] |
|
At our meeting, we agreed that it's not yet worth adding the real mechanisms to generate what will inevitably be a fake LSF for pfsObject. We'll fake out the mechanism so we can get something out the back end quickly. |
| Comment by price [ 22/Jan/21 ] |
|
Added the products to the pipeline, and added tests in the weekly to ensure they're created. |
| Comment by price [ 23/Jan/21 ] |
|
Merged to master. |