[PIPE2D-665] Use better interpolation in generating sky1D Created: 05/Dec/20 Updated: 01/Sep/21 Resolved: 01/Sep/21 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | rhl | Assignee: | price |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Sprint: | 2DDRP-2021 A 8 | ||||||||
| Reviewers: | hassan | ||||||||
| Description |
|
The current code to generate sky1d uses linear interpolation. We need to do better. Because of dithering of wavelengths relative to the pixel grid we should not have problems with under sampling. A least-squares spline might be a way to get something running quickly |
| Comments |
| Comment by rhl [ 11/Dec/20 ] |
|
After merging This ticket still needs to be done, as it allows us to handle under-sampling using dithers. |
| Comment by price [ 26/Aug/21 ] |
|
This includes some work to refactor FitFocalPlaneTask and FocalPlaneFunction to make it easier to use and to extend (see also |
| Comment by hassan [ 28/Aug/21 ] |
|
In general looks fine. Minor comments added. |
| Comment by price [ 01/Sep/21 ] |
|
Addressed comments and merged. |