[PIPE2D-663] Reconsider the API for pfs.drp.stella.fitFocalPlane.FocalPlaneFunction Created: 05/Dec/20 Updated: 29/Jan/22 Resolved: 01/Sep/21 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | rhl | Assignee: | price |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Sprint: | 2DDRP-2021 A 2 |
| Description |
|
In order to return a sky spectrum for fiberId fid the current code looks like:
pfsSky1D = butler.get('sky1d', dataId)
sky = pfsSky1D([wavelength], pfsConfig.extractCenters([fid])[0]
The sky spectrum for a given fibre depends on the fibre as well as the position in the focal plane, so I think that we probably want an API more like pfsSky1D(pfsConfig, [wavelength], [fid]) An additional semi-trivial point is that it's a little awkward to specify arrays of wavelengths and fiberIds when I want the sky spectrum for a single object. It might be worth adding some syntactic sugar. |
| Comments |
| Comment by rhl [ 11/Dec/20 ] |
|
Less important once I discovered that we have pfsMerged.sky |
| Comment by price [ 26/Aug/21 ] |
|
I revised the FocalPlaneFunction API as part of |
| Comment by price [ 01/Sep/21 ] |
|
|