[PIPE2D-660] Differential full-detector detectorMap Created: 04/Dec/20 Updated: 13/Feb/21 Resolved: 13/Feb/21 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | price | Assignee: | price |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Sprint: | 2DDRP-2021 A, 2DDRP-2021 A 2 | ||||||||
| Reviewers: | hassan | ||||||||
| Description |
|
GlobalDetectorMap appears to do a decent job of modeling the position of arc lines, but it may suffer precision at the upper and lower edges, where there are few lines (due to the dichroic and detector response). What is wanted is a differential correction to the design. I envision this as using the machinery invented for GlobalDetectorMap, but making it relative to the SplinedDetectorMap generated by the simulator. |
| Comments |
| Comment by price [ 19/Dec/20 ] |
|
There's something wrong with the slit offsets mechanism: measured offsets don't appear to be applied effectively. |
| Comment by price [ 13/Jan/21 ] |
|
This is working, and generating fits with a similar quality as the GlobalDetectorMap, but with lower polynomial order, so it's a net win. |
| Comment by price [ 30/Jan/21 ] |
|
I propose that the right time to merge this is just before our regular arc processing system ( |
| Comment by price [ 30/Jan/21 ] |
|
Note also that there will be merge conflicts with |
| Comment by price [ 13/Feb/21 ] |
|
Stakeholders at a recent meeting confirmed that merging was acceptable. Merged to master. |