[PIPE2D-652] createHash() should truncate to 63 bits, not 64 Created: 07/Nov/20  Updated: 05/Jan/21  Resolved: 09/Nov/20

Status: Won't Fix
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Normal
Reporter: hassan Assignee: hassan
Resolution: Won't Fix Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to DAMD-93 Clarify that hash is 63-bit Won't Fix
Story Points: 1
Sprint: 2DDRP-2021 A

 Description   

The SHA generation function:

https://github.com/Subaru-PFS/datamodel/blob/fa98c08c8ac839956f0d4e8489523e4898894a8b/python/pfs/datamodel/utils.py#L51

Generates a 64-bit share, that is not consistent with the 63-bit truncation specified in the datamodel.txt

Please update it to be in line with the datamodel specification.

 

 Comments   
Comment by hassan [ 09/Nov/20 ]

Withdrawn. Follow approach of using all 64 bits, and encoding into a signed 64-bit integer.

Generated at Sat Feb 10 15:56:03 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.