[PIPE2D-635] Improve FitFocalPlaneTask Created: 29/Sep/20 Updated: 05/Jan/21 Resolved: 22/Oct/20 |
|
| Status: | Done |
| Project: | DRP 2-D Pipeline |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Normal |
| Reporter: | price | Assignee: | price |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Story Points: | 4 | ||||||||||||
| Sprint: | 2DDRP-2021 A | ||||||||||||
| Reviewers: | hassan | ||||||||||||
| Description |
|
The implementation of FitFocalPlaneTask is currently a placeholder, and its shortcomings are starting to be felt. Upgrade its capabilities, so that it implements rejection and handles errors (input and output). Check that this solves the problems from One thing that may be required is to increase the number of sky fibers in the integration test (e.g., science/sky/fluxstd from 7/2/1 to 4/5/1 or 8/5/2). If modifying the pfsDesign files, Kiyoto Yabe has particular science objIds that I should be sure to include (e.g., 0x37). |
| Comments |
| Comment by Kiyoto Yabe [ 01/Oct/20 ] |
|
I'm happy if you include objId = 0x12, 0x37, 0x69, and 0x1 (fluxstd). |
| Comment by price [ 03/Oct/20 ] |
|
Upgraded the FitFocalPlaneTask and expanded the number of fibers in the integration test. Discovered that the simulator isn't including the gain, so fixed that at the same time, to avoid multiple quick updates to the integration test dataset. |
| Comment by Kiyoto Yabe [ 09/Oct/20 ] |
|
Thank you for this implementation. I did checkout the branch and run the process, and I no longer see the feature at ~633 nm. The redshift determination by DRP1D seems to be reasonable as well. Great! |
| Comment by price [ 22/Oct/20 ] |
|
Merged to master. |