[PIPE2D-612] drp install failed (test failed) Created: 24/Jun/20  Updated: 05/Jan/21  Resolved: 26/Jun/20

Status: Won't Fix
Project: DRP 2-D Pipeline
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Normal
Reporter: fmadec Assignee: price
Resolution: Won't Fix Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: File pytest-drp_stella.xml.failed    
Sprint: 2DDRP-2021 A

 Description   

got an error after doing a fresh install (./install_pfs.sh -t current /software/drp)

Failed test output:
Global pytest output is in /software/drp/pfs/drp_stella/tests/.tests/pytest-drp_stella.xml.failed
The following tests failed:
/software/drp/pfs/drp_stella/tests/.tests/pytest-drp_stella.xml.failed
1 tests failed
scons: *** [checkTestStatus] Error 1
scons: building terminated because of errors.


 Comments   
Comment by price [ 25/Jun/20 ]

Do you have git lfs installed and available?

Comment by fmadec [ 25/Jun/20 ]

yes :

 

 

git version 2.18.2

git-lfs/2.4.1 (GitHub; linux amd64; go 1.9.4) 

Package rh-git218-git-lfs-2.4.1-3.el7.x86_64 already installed and latest version

 

 

 

Comment by fmadec [ 25/Jun/20 ]

restarted the same command today:

and it seems that the first failure is :

 

 

 

================================================ FAILURES ================================================
_______________________________________ NevenPsfTestCase.testBasic _______________________________________
self = <test_NevenPsf.NevenPsfTestCase testMethod=testBasic>
def setUp(self):
 drpPfsData = getPackageDir("drp_pfs_data")
 detMapFilename = os.path.join(drpPfsData, "detectorMap", "detectorMap-2019Apr-r1.fits")
> self.detMap = pfs.drp.stella.DetectorMap.readFits(detMapFilename)
tests/test_NevenPsf.py:25: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
python/pfs/drp/stella/detectorMapContinued.py:113: in readFits
 with astropy.io.fits.open(pathName) as fits:

 

the script is supposed to git clone (or whatever) everything it needs to performa the install and the test, right ?

where those files supposed to be stored ?

 

 

 

Comment by price [ 25/Jun/20 ]

That file is $DRP_PFS_DATA_DIR/detectorMap/detectorMap-2019Apr-r1.fits. What are its contents? I suspect it's not a FITS file, or it's corrupt. Can you open it with fv or similar?

Comment by fmadec [ 26/Jun/20 ]

As expected they are not fits file.

but the question is why ? => git-lfs : yes but why ?

 

I suggest you try an install from scratch (with a fresh OS install !)

The machine on which I try to install drp is a centos:

CentOS Linux release 7.8.2003 (Core)

git package installed:

 

yum list installed|grep git

crontabs.noarch 1.11-6.20121102git.el7 @anaconda 
git.x86_64 1.8.3.1-23.el7_8 @updates 
git-lfs.x86_64 2.10.0-1.el7 @epel 
libglvnd.x86_64 1:1.0.1-0.8.git5baa1e5.el7 @base 
libglvnd-egl.x86_64 1:1.0.1-0.8.git5baa1e5.el7 @base 
libglvnd-glx.x86_64 1:1.0.1-0.8.git5baa1e5.el7 @base 
linux-firmware.noarch 20191203-76.gite8a0f4c.el7 @base 
rh-git218.x86_64 3.2-1.el7 @centos-sclo-rh
rh-git218-git.x86_64 2.18.2-1.el7 @centos-sclo-rh
rh-git218-git-core.x86_64 2.18.2-1.el7 @centos-sclo-rh
rh-git218-git-core-doc.noarch 2.18.2-1.el7 @centos-sclo-rh
rh-git218-git-lfs.x86_64 2.4.1-3.el7 @centos-sclo-rh
rh-git218-perl-Git.noarch 2.18.2-1.el7 @centos-sclo-rh
rh-git218-runtime.x86_64 3.2-1.el7 @centos-sclo-rh
screen.x86_64 4.1.0-0.25.20120314git3c2946.el7

 

 

I have in the .bash_profile:

source scl_source enable devtoolset-8 rh-git218

 

So I don't understand why it is not working properly

 

 

Comment by hassan [ 26/Jun/20 ]

Did you run git lfs install as the final step of the git lfs installation?

https://github.com/Subaru-PFS/drp_doc/blob/master/pipelineUser/installation.rst

Comment by fmadec [ 26/Jun/20 ]

Thanks Hassan!

it was that!
I missed that step in the install

it works now

Comment by hassan [ 26/Jun/20 ]

Problem understood and no update is required in the 2D DRP software.

Generated at Sat Feb 10 15:55:24 JST 2024 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.